Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow nixpkgs-review to build insecure packages #391

Merged
merged 2 commits into from
Apr 28, 2024
Merged

allow nixpkgs-review to build insecure packages #391

merged 2 commits into from
Apr 28, 2024

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Feb 28, 2024

Closes #385

extra-nixpkgs-config requires nixpkgs-review 2.9.0, to merge this PR the flake will need to be updated as it currently has 2.8.0.

Updating the flake requires fixing some haskell breakage, not sure how trivial that is.

For now I can just override the runtime dependencies so this can be deployed.

@mweinelt
Copy link
Member

mweinelt commented Feb 28, 2024

Note that this is relevant for nixpkgs, since openssl_1_1 is exceptionally built by hydra, because of https://github.com/NixOS/nixpkgs/blob/master/pkgs/top-level/release.nix#L31-L38.

zowoq added 2 commits April 28, 2024 12:07
this is only intended to be temporary until the flake is updated
@zowoq zowoq marked this pull request as ready for review April 28, 2024 02:15
@zowoq zowoq merged commit df23e62 into nix-community:main Apr 28, 2024
7 checks passed
@zowoq zowoq deleted the insecure branch April 28, 2024 02:15
@zowoq
Copy link
Contributor Author

zowoq commented Jun 25, 2024

@mweinelt Should I revert this now openssl_1_1 is disallowed? NixOS/nixpkgs@b0b4d2d

@mweinelt
Copy link
Member

I think so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run nixpkgs-review with NIXPKGS_ALLOW_INSECURE=1
2 participants